Code Reviews

Hector Zarate (@hecktorzr)

Explain me like Im ve:

self.window = [[UIWindow alloc] initWithFrame:screenFrame]; //self.window = [[UIWindow alloc] initWithFrame:screenFrame]; self.window.backgroundColor = [UIColor whiteColor].CGColor; [self.window setRootViewController:[[CAViewController alloc] init]]; [self.window makeKeyAndVisible]; return NO;

_ _
self.window = [[UIWindow alloc] initWithFrame:screenFrame]; //self.window = [[UIWindow alloc] initWithFrame:screenFrame]; self.window.backgroundColor = [UIColor whiteColor].CGColor; [self.window setRootViewController:[[CAViewController alloc] init]]; [self.window makeKeyAndVisible]; return NO;


self.window = [[UIWindow alloc] initWithFrame:screenFrame]; self.window.backgroundColor = [UIColor clearColor]; [self.window setRootViewController:[[CAViewController alloc] init]]; [self.window makeKeyAndVisible]; return YES;

in brief: extra pairs of eyes looking at some code to ensure correctness.

Benets:

A better, harder, faster stronger codebase

Spotting bugs at an earlier stage

(domain / product knowledge and technical knowledge)

Sharing Knowledge

Better Developers

(There's no such thing as a free lunch)

Downs:

Downs
Dependencies Workow bottle-necks

Common Pitfalls:

Speed
Doing them to fast to spot anything

Taking it too personal

Skipping them

Everybody needs them, even the seniors and the leads.

Selective skipping

Workows:

Workows:
Fork / Pull-Request Including different tools like Gerrit AA-Style

Questions?
hector.zarate@infullmobile.com