Code Review of EXPO 2020 Web Application

Section No /
S. No. Module Name File Name
Line No.
1 All
app\modules\core\mock-
2 App/Core data-service\mock-data- 19
service.ts

3 All

4 App/Core web-worker.interface

5 App/Core theme.interface.ts

services\logger-service\
6 App/Core
logger.service.ts

7 App/Core mock-data-service

8 All

9 App/User/Shared data-display-selector

10 Style/Global mixin.scss

11 Theme theme-customization.scss

bootstrap-module-
12 Style/Global
loader.scss

13 Style/Global variable.scss

14 Style/Global common.scss 3

15 Style/Global app\app.component.scss

16 Style/Global common.scss
57
17 Style/Global common.scss 62
18 Style/Global common.scss
19 Style/Global common.scss 1
20 Style/Global common.scss 29

21 Style/User/Layout

22 All angular.json

Restricted
 23 All
24

25 App/User

data-display-
26 data display selector
selector.component.scss

falcon-
27 falcon-eye
eye.component.html

28 falcon-eye falcon-selector

all falcon eye module ts

29 falcon-eye
files
all falcon eye module html
30 falcon-eye
files
all falcon eye module html
31 falcon-eye files
falcon-
32 falcon-eye
sidenav.component.ts 42
33 falcon-eye falcon-
sidenav.component.ts 202

falcon-
34 falcon-eye
sidenav.component.scss
40
35 header header.component.scss
50
36 header header.component.scss
56
37 header header.component.scss
56
ChangeRoleViewComp change-role-
38
onent view.component.html

ChangeRoleViewComp change-role-
39
onent view.component.html
2
ChangeRoleViewComp change-role-
40 onent view.component.scss 97
ChangeRoleViewComp change-role-
41
onent view.component.ts 33

Restricted
 ChangeRoleViewComp change-role-
42
onent view.component.ts 38

site-infra-bar-
graph.component.scss,
native-
species.component.scss,
pest-
43 User/libraries/sidebar species.component.scss,
water-
leak.component.scss,
water-
consumption.component.s
css

site-infra-bar-
graph.component.ts,
native-
species.component.ts,
44 User/libraries/sidebar pest-
species.component.ts,
water-leak.component.ts,
water-
consumption.component.t
s

dynamic-
45 User/libraries/sidebar
layout.interface.ts
site-infra-bar-
46 User/libraries/sidebar graph.component.scss
54, 76
site-infra-bar-
47 User/libraries/sidebar graph.component.scss
36, 53, 75

native-
48 User/libraries/sidebar species.component.scss
34, 56

49 User/libraries/sidebar native-
species.component.scss
33, 55

pest-
50 User/libraries/sidebar
species.component.scss
23

51 User/libraries/sidebar pest-
species.component.scss
13, 22
52 User/libraries/sidebar water-
leak.component.scss 26

Restricted
 water-
53 User/libraries/sidebar
leak.component.scss 16, 25,52
Total no of
Major
Defects
Total no of
Minor
defects

Restricted
plication
Description of Review Comment Severity Reviewed By Review Date

use /assets in scss file instead of ../../…/assets Minor Sandip 2020-02-11

Minor Sandip 2020-02-11
use /assets in mock-data-service file instead of
../../…/assets

remove font-family from all css selector, it will be there Major Sandip 2020-02-11
only on html tag
Major Sandip 2020-02-11
web-worker.interface move to interface
Major Sandip 2020-02-11
theme.interface.ts move to interface
Major Sandip 2020-02-11
move ILogInterface into interface

move mock-data-service folder to service folder and for Major Sandip 2020-02-11
folder name no need service suffix again
only pipe and directives will be there in shared module no Minor Sandip 2020-02-11
services
remove data-display-selector component from Minor Sandip 2020-02-11
user/shared module
no color code at mixin, if required pass as param Major Sandip 2020-02-15
direct css style shouldn't be there inside theme- Major Sandip 2020-02-15
customization.scss
Major Sandip 2020-02-15
what is the use of bootstrap-module-loader.scss, if we are
using then load inside the specific theme file

Major Sandip 2020-02-15

color shouldn't be in variable.scss file put into color.scss

no need of these code in common.scss file at line 3, Major Sandip 2020-02-15

bootstrap already handled normalization for us
Minor Sandip 2020-02-15
remove unwanted css in these files
Minor Sandip 2020-02-15
remove unwanted css in these files (.menu-container)
don't use style direct element tag Major Sandip 2020-02-15
move @font-face code at top of the page Minor Sandip 2020-02-15
remove unwanted imports like Minor Sandip 2020-02-15
no color code should be here Major Sandip 2020-02-15
Major Sandip 2020-02-15

layout issue in blank page , it should have it's own

positioning set like add height 100vh at #_mdspcontent
font import shouldn't be here Major Sandip 2020-02-15

Restricted
use internationalization Major Sandip 2020-02-15
remove all console.log use logger service Major Sandip 2020-02-15
Major Sandip 2020-02-15

create folder user-layout and move these components

under this:- - user component - bottom-navigation -
header - notification-panel - side-bar - threejs in future
Major Ashima 2020-02-25

Move all color related code to styles folder

Minor Ashima 2020-02-25

instead of creating another component (falcon-side-nav),

code can be directly written in this component and
falcon-side-nav compenent can be removed
falcon-selector component can be removed since it is not Minor Ashima 2020-02-25
getting used anywhere.
Minor Ashima 2020-02-25
Remove console log and use loggerservice
Minor Ashima 2020-02-25
For accessing assets folder, directly use '/assets'
Minor Ashima 2020-02-25
Don't use style attribute in html. Prefer writing a class.
Minor Ashima 2020-02-27
delay is not used anywhere. Should be removed
Minor Ashima 2020-02-27
getEnvClass is not getting used anywhere. Should be remo

Minor Ashima 2020-02-27

font-size: 1rem; can be inherited from body.

Minor Ashima 2020-03-18

No need of giving box-sizing property. It will be inerited.
Minor Ashima 2020-03-18
No need of giving z-index. It is getting inherited from
bootstrap
Need to provide font-family as expooffice. Bootstrap is Minor Ashima 2020-03-18
attaching its own font family
Major Ashima 2020-03-18
Rename Close.svg to close.svg
Minor Ashima 2020-03-18

Keep role change header, classifications, action under one

more div wrapper. And give margin, width to this wrapper
instead of repeating it 3 times.
Minor Ashima 2020-03-18
font-size: 1rem can be inherited from body.
Minor Ashima 2020-03-18
bsModalRef can be made private since it is not getting
used outside the component

Restricted
 Minor Ashima 2020-03-18
Remove unused argument
Minor Sreedhar 2020-06-12

Move all color codes to separate file

Minor Sreedhar 2020-06-12

Auto format tslint issues (spacing issues and replace ' with
")
Minor Sreedhar 2020-06-12
All interface name should start with I (eg: ILibrary)
Minor Sreedhar 2020-06-12
Line height of 48px can be converted to rem value (3rem)
Minor Sreedhar 2020-06-12
Remove commented and un-used codes
Minor Sreedhar 2020-06-12

Line height of 48px can be converted to rem value (3rem)

Minor Sreedhar 2020-06-12

Remove commented and un-used codes

Minor Sreedhar 2020-06-12

Line height of 48px can be converted to rem value (3rem)

Minor Sreedhar 2020-06-12

Remove commented and un-used codes

Minor Sreedhar 2020-06-12
Line height of 48px can be converted to rem value (3rem)

Restricted
 Minor Sreedhar 2020-06-12
Remove commented and un-used codes

19

29

Restricted
Assigned Developer Defect Category Fixed Date Decision

All scss
Yatish
js/ts

All
scss

Ashima Accepted
js/ts
14-02-2020
Ashima Accepted
js/ts
14-02-2020
Yatish
js/ts

Yatish
js/ts

All
angular

Ashima Rejected
js/ts

All css
Sankar
css

Yatish
css

Sankar
css

Sankar
css

Ashima Accepted
css
14-02-2020
Ashima Accepted
css
14-02-2020
Ashima css 14-02-2020 Accepted
Sankar css
Ashima css
Sankar css
Ashima
css

Sankar js/ts

Restricted
All js/ts
All js/ts
Ashima Accepted

js/ts
Sankar

css
Sankar

3/3/2020 Accepted

html
Sankar
3/3/2020 Duplicate
html, css, ts
Sankar
3/3/2020 Duplicate
js/ts
Sankar
3/3/2020 Accepted
html
Sankar
3/3/2020 Accepted
html
Sankar
3/3/2020 Accepted
ts
Sankar
4/3/2020 Rejected
ts
Sankar
4/3/2020 Accepted
css
Sreedhar
Accepted
css 19/3/2020
Sreedhar
Rejected
css 19/3/2021
Sreedhar
Accepted
css 19/3/2022
Sreedhar
Accepted
img 19/3/2023
Sreedhar

Accepted

html 19/3/2024
Sreedhar
Accepted
css 19/3/2025
Sreedhar
Accepted
ts 19/3/2026

Restricted
Sreedhar
Accepted
ts 19/3/2027
Yatish

css
Yatish

js/ts
Yatish
js/ts
Yatish
css
Yatish
css
Yatish

css
Yatish

css
Yatish

css
Yatish

css
Yatish
css

Restricted
Yatish
css

Restricted
 Remarks
[Reason for rejection]

Moved to src/app/modules/core/interfaces/web-worker

Moved to src/app/modules/core/interfaces/theme

This will be a common component

Done

Done
Done

Restricted
Done

It was a part of older falcon eye layout where data display was part of it,later moved to bottom navigation.
Reduntant code is removed

That Portion is removed as per S. No. 27

That Portion is removed as per S. No. 27

It will be resued when we would be having actual data

popover z-index should be less than modal z-index, otherwise it it will appear on top of all modal popups.

Upper case to lower case changes are not getting reflected in source tree. I'll give a new name.

Restricted
Restricted
Restricted
 Defect Fix
Status
verification

Restricted
Closed Closed

Closed Closed

Closed Closed

Closed Closed

Open Open

Closed Closed

Closed Closed

Closed Closed

Closed Closed

Closed Closed

Closed Closed

Closed Closed

Closed Closed

Closed Closed

Closed Closed

Restricted
Closed Closed

Restricted
Restricted