Professional Documents
Culture Documents
Code Review Checklist A4
Code Review Checklist A4
Code Review Checklist A4
Implementation Dependencies
If this change requires updates outside of the
Does this code change do what it is supposed to
code, like updating the documentation,
do?
configuration, readme files, was this done?
Can this solution be simplified?
Might this change have any ramifications for
Does this change add unwanted compile-time or
other parts of the system, or backward
run-time dependencies?
compatibility?
Was a framework, API, library, service used that
Can you think of any use case in which the Do you see any potential to improve the
usability perspective?
Is error handling done the correct way? Is the API well documented?
Should any logging or debugging information Is the proposed solution (UI) accessible?
debugging?
www.michaelagreiler.com
Code Review Checklist 2/2
Readability Exercise
Was the code easy to understand?
Which parts of the checklist are you already
Which parts were confusing to you and why?
considering?
Can the readability of the code be improved by
Which aspect aren't you focusing on during
smaller methods?
code reviews and why?
Can the readability of the code be improved by
Do you think some aspects are more important
different function/method or variable names?
that others? Why? Why not?
Is the code located in the right
Do you feel you would benefit from additional
file/folder/package?
training in some areas (e.g., security,
Do you think certain methods should be
accessibility)?
restructured to have a more intuitive control
flow?
better?
understandable?
(unit/integration/system tests)?
change?
Experts Opinion
Do you think a specific expert, like a security
www.michaelagreiler.com